docker/local-emulator/qemu/build-image.sh (1)

277-280: Verify BUILD_ENV_FILE is set before use.

BUILD_ENV_FILE is used on line 277 (cp "$BUILD_ENV_FILE" ...) but is only set later on line 393. Since build_one is called from the loop starting at line 395, which comes after line 393, this should work correctly in practice.

However, if someone were to call build_one directly or reorder the script, this would fail. Consider moving the env generation to the top of the script or passing BUILD_ENV_FILE as a parameter to build_one.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docker/local-emulator/qemu/build-image.sh` around lines 277 - 280, The script
copies BUILD_ENV_FILE inside build_one but BUILD_ENV_FILE is only set later, so
ensure build_one always has a valid BUILD_ENV_FILE: either (a) move the
generation of BUILD_ENV_FILE to run before build_one is ever called, or (b)
change build_one to accept BUILD_ENV_FILE as a parameter and validate it at the
top of build_one (error out if unset or non-readable) before the cp
"$BUILD_ENV_FILE" "$bundle_dir/build.env" line; reference the build_one function
and the BUILD_ENV_FILE variable when making the change so callers are updated
accordingly.

docker/local-emulator/qemu/test-serial.sh (1)

104-109: Polling loop prints duplicate STACK_PROVISION lines on every iteration.

The current logic greps all STACK_PROVISION lines every 2 seconds, so the same lines are printed repeatedly until success or timeout. This clutters the output.

🔧 Track last printed line count to show only new lines

 elapsed=0
 timeout=120
+last_provision_lines=0
 while [ "$elapsed" -lt "$timeout" ]; do
   if grep -q "STACK_CLOUD_INIT_DONE" "$TMP_DIR/serial.log" 2>/dev/null; then
     echo ""
     echo "=== SUCCESS: STACK_CLOUD_INIT_DONE received ==="
     echo ""
     echo "=== All STACK_PROVISION lines ==="
     grep "STACK_PROVISION" "$TMP_DIR/serial.log" || echo "(none found)"
     exit 0
   fi

   # Show any STACK_PROVISION lines as they appear
-  if grep -q "STACK_PROVISION" "$TMP_DIR/serial.log" 2>/dev/null; then
-    grep "STACK_PROVISION" "$TMP_DIR/serial.log" | while IFS= read -r line; do
-      echo "  [${elapsed}s] $line"
-    done
-  fi
+  current_lines=$(grep -c "STACK_PROVISION" "$TMP_DIR/serial.log" 2>/dev/null || echo 0)
+  if [ "$current_lines" -gt "$last_provision_lines" ]; then
+    grep "STACK_PROVISION" "$TMP_DIR/serial.log" | tail -n +$((last_provision_lines + 1)) | while IFS= read -r line; do
+      echo "  [${elapsed}s] $line"
+    done
+    last_provision_lines=$current_lines
+  fi

   sleep 2

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@docker/local-emulator/qemu/test-serial.sh` around lines 104 - 109, The
polling loop prints duplicate STACK_PROVISION lines because each iteration greps
the entire "$TMP_DIR/serial.log"; change it to print only new lines by tracking
the last printed line count (e.g., last_provision_lines or last_index) and using
tail (or grep with tail -n +<last+1>) against "$TMP_DIR/serial.log" instead of
re-grepping the whole file; update the counter after printing (use the number of
lines currently matching STACK_PROVISION via grep -c or wc -l) so subsequent
iterations only echo new STACK_PROVISION entries and avoid duplicates while
still showing elapsed with each new line.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

.github/workflows/qemu-emulator-build.yaml (1)

83-103: Arm64 is no longer boot-validated in this workflow.

With the build-job runtime checks gated to amd64 and the test job only covering amd64, the packaged arm64 qcow2 never gets a post-build boot check. That makes first-boot regressions in the final image releasable. Please add a lightweight arm64 boot/readiness check instead of dropping validation entirely.

Also applies to: 121-130

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/qemu-emulator-build.yaml around lines 83 - 103, The
workflow currently only starts and verifies the emulator when matrix.arch ==
'amd64', leaving arm64 qcow2 unvalidated; update the steps "Start emulator and
verify", "Verify services are healthy", and "Stop emulator" to also run for
arm64 but in a lightweight smoke-check mode: change the if conditions to include
matrix.arch == 'arm64' as well, and when matrix.arch == 'arm64' set a flag/env
var (for example EMULATOR_SMOKE_CHECK=true or EMULATOR_MODE=smoke) and reduced
checks/timeouts (e.g. EMULATOR_READY_TIMEOUT lower and fewer service probes)
before invoking docker/local-emulator/qemu/run-emulator.sh with
EMULATOR_ARCH=${{ matrix.arch }} so the arm64 image receives a minimal
boot/readiness validation without full amd64-length testing.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes